Skip to content
This repository was archived by the owner on Jan 4, 2025. It is now read-only.

_UPLOAD_VAT_INVOICE_#165

Merged
GriceTurrble merged 3 commits intopython-amazon-mws:masterfrom
masavini:master
Jun 25, 2020
Merged

_UPLOAD_VAT_INVOICE_#165
GriceTurrble merged 3 commits intopython-amazon-mws:masterfrom
masavini:master

Conversation

@masavini
Copy link
Copy Markdown
Contributor

@masavini masavini commented Mar 19, 2020

added UPLOAD_VAT_INVOICE support

masavini added 3 commits March 19, 2020 12:27
@masavini
Update mws.py
f066b56 
added FeedOptions and b64encode for pdf file
@masavini
Update mws.py
cd2bd93
@masavini
Update mws.py
a896e13
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 19, 2020 •
edited
Loading

Codecov Report

Merging #165 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #165   +/-   ##
=======================================
  Coverage   46.92%   46.92%           
=======================================
  Files           4        4           
  Lines         635      635           
  Branches       64       64           
=======================================
  Hits          298      298           
  Misses        326      326           
  Partials       11       11
Impacted Files Coverage Δ
mws/mws.py 44.82% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f808921...a896e13. Read the comment docs.

@Bobspadger
Copy link
Copy Markdown
Member

Bobspadger commented Mar 20, 2020

Thanks for the PR @masavini

Could you please re-submit against develop ?

@masavini
Copy link
Copy Markdown
Contributor Author

masavini commented Mar 20, 2020

Thanks for the PR @masavini

Could you please re-submit against develop ?

just done...

@GriceTurrble
Copy link
Copy Markdown
Member

GriceTurrble commented May 2, 2020

See #166 for comments.

@Bobspadger Should we continue attempting to merge this for a 0.x release? It's a minor change overall, but I imagine the impact for sellers in EU and GB regions is significant.

@Bobspadger
Copy link
Copy Markdown
Member

Bobspadger commented May 4, 2020

I think its probably worth it. I'd like to try and give it a test but struggling with time at the moment, not sure if anyone else is able to ?

@kwmiebach kwmiebach mentioned this pull request May 21, 2020
Closed
GriceTurrble
GriceTurrble approved these changes Jun 25, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@GriceTurrble GriceTurrble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been sitting idle for some time, so going to accept as-is. However, I will add an enhancement that accepts a dict argument and then processes that dict into the appropriate string value (per comments made on this #166 ).

@GriceTurrble GriceTurrble merged commit 6ba7851 into python-amazon-mws:master Jun 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@GriceTurrble GriceTurrble GriceTurrble approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@masavini @Bobspadger @GriceTurrble