add all current marketplaces and alphabetize by country code#155
add all current marketplaces and alphabetize by country code#155GriceTurrble merged 5 commits intopython-amazon-mws:developfrom agritheory:develop
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #155 +/- ##
===========================================
+ Coverage 77.39% 77.51% +0.11%
===========================================
Files 18 18
Lines 960 965 +5
Branches 92 92
===========================================
+ Hits 743 748 +5
Misses 212 212
Partials 5 5
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## develop #155 +/- ##
===========================================
- Coverage 77.39% 77.37% -0.03%
===========================================
Files 18 18
Lines 960 959 -1
Branches 92 92
===========================================
- Hits 743 742 -1
Misses 212 212
Partials 5 5
Continue to review full report at Codecov.
|
GriceTurrble
left a comment
GriceTurrble
left a comment
There was a problem hiding this comment.
Similar comment as on #154 , but it seems this is also missing the AE region. Can you double check, please?
Yes, copy paste mistake with the AE marketplace, good catch. |
|
@GriceTurrble Is there a test for this and if not, what would be a reasonable thing to add? |
There is a small test case in python-amazon-mws/tests/request_methods/test_mws.py Lines 15 to 25 in 8004de5 The latter of these two tests is a bit trivial (testing that a hard-coded value remains hard-coded correctly), but the former makes sense: ensuring that the domain is returned correctly for a chosen marketplace, which dictates how the request URI is built. If you want to do a bit of busywork to extend that and cover all the domains, that would be appreciated. Otherwise I'll just accept this as-is later today. :) |
I think it makes sense to explicitly assert that UK and GB are the same and agree that the rest is busywork. I would prefer to add the tests before you merge and keep the fire lit! |
|
@GriceTurrble Galen, please review the tests I added when you get a chance. |
* upstream/develop: Add Feeds utility to convert dict FeedOptions to string (python-amazon-mws#181) Ensure correct decoding of bytes (python-amazon-mws#168) Compatibility fix (python-amazon-mws#124) Implement a couple of function for the OutboundShipments API. (python-amazon-mws#96) Added OutboundShipments.create_fulfillment_order (python-amazon-mws#95) added UpdateReportAcknowledgements (python-amazon-mws#101) Update feeds.py (python-amazon-mws#166) added easyship api support for indian marketplace (python-amazon-mws#169) Moving Slack link up, removing gitter chat link add all current marketplaces and alphabetize by country code (python-amazon-mws#155) Updated slack invite link Slack invite link (python-amazon-mws#152) Slack invite link fix clean_params (python-amazon-mws#106) add in NL marketplace information Fix flake8 warnings Update develop branch CI + package metadata include mws.apis in setup.py Fix bug: Remove trailing comma
2 participants
Several more marketplaces have been added since I looked at this last:
https://docs.developer.amazonservices.com/en_US/dev_guide/DG_Endpoints.html