This repository was archived by the owner on Jan 4, 2025. It is now read-only.
added UpdateReportAcknowledgements#101
Merged
GriceTurrble merged 2 commits intopython-amazon-mws:developfrom Jun 25, 2020
Merged
added UpdateReportAcknowledgements#101GriceTurrble merged 2 commits intopython-amazon-mws:developfrom
GriceTurrble merged 2 commits intopython-amazon-mws:developfrom
Conversation
Contributor
|
Thank you looks good. Probably we should implement the second optional parameter in your linked documentation, too? |
Contributor
Author
|
Hi,
/I just found a bug not in this code, remember to use 'false' instead of
False for now./
Yes, Sure. To me It is a well-known bug
/
/
/Probably we should implement the second optional parameter in your
linked documentation, too?/
/I know you shouldnt need it, but for the sake of completeness?/
//
/Parameter is Acknowledged, its default is true./
Ok, I will have a look.
…On 29/01/19 04:04, Florian Benkö wrote:
Thank you looks good.
I just found a bug not in this code, remember to use 'false' instead
of False for now.
Probably we should implement the second optional parameter in your
linked documentation, too?
I know you shouldnt need it, but for the sake of completeness?
Parameter is Acknowledged, its default is true.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#101 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/Ab7RIEH6ImSmTWXHqASC17glgbiJv3chks5vH7ongaJpZM4ZYGax>.
|
GriceTurrble
previously requested changes
Feb 25, 2020
Member
There was a problem hiding this comment.
Coming at this late, apologies for the delay. :)
Looks good, straightforward addition.
Can you please add the Acknowledged parameter into the request method, as well? Once that's in, I can approve the merge. Or I'll just have to edit it in later.
Thank you. :)
Added `acknowledged` boolean parameter; cleaned up dict structure
GriceTurrble
dismissed
their stale review
Made changed myself; approving and merging newer version.
GriceTurrble
approved these changes
Jun 25, 2020
Lacrymology
added a commit
to Shiphero/python-amazon-mws
that referenced
this pull request
Jul 10, 2020
* upstream/develop: Add Feeds utility to convert dict FeedOptions to string (python-amazon-mws#181) Ensure correct decoding of bytes (python-amazon-mws#168) Compatibility fix (python-amazon-mws#124) Implement a couple of function for the OutboundShipments API. (python-amazon-mws#96) Added OutboundShipments.create_fulfillment_order (python-amazon-mws#95) added UpdateReportAcknowledgements (python-amazon-mws#101) Update feeds.py (python-amazon-mws#166) added easyship api support for indian marketplace (python-amazon-mws#169) Moving Slack link up, removing gitter chat link add all current marketplaces and alphabetize by country code (python-amazon-mws#155) Updated slack invite link Slack invite link (python-amazon-mws#152) Slack invite link fix clean_params (python-amazon-mws#106) add in NL marketplace information Fix flake8 warnings Update develop branch CI + package metadata include mws.apis in setup.py Fix bug: Remove trailing comma
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added UpdateReportAcknowledgements