bpo-34264: [macOS] make stack size of created threads same as on main… - #8534
Closed
ronaldoussoren wants to merge 2 commits into
Closed
bpo-34264: [macOS] make stack size of created threads same as on main…#8534ronaldoussoren wants to merge 2 commits into
ronaldoussoren wants to merge 2 commits into
Conversation
… thread This changes the default stack size for threads created through the threading module the same as the stack size of the main thread on macOS.
Contributor
Author
|
Ned could you please review before I merge (mostly because this would be my first commit to CPython in a long time)? |
Contributor
Author
|
No longer relevant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in the BPO issue the default stack sizes for the main thread and secondary threads is inconsistent on macOS, even though both claim to be chosen to a minimal value that works correctly with the default recursion limit.
This pull request increases the default stack size of secondary threads to match that of the main thread.
https://bugs.python.org/issue34264