Skip to content

bpo-34161 Removed additional parens - #8350

Merged
Mariatta merged 1 commit into
python:masterfrom
aaqaishtyaq:bpo-34161-parens-fixed
Jul 20, 2018
Merged

bpo-34161 Removed additional parens#8350
Mariatta merged 1 commit into
python:masterfrom
aaqaishtyaq:bpo-34161-parens-fixed

Conversation

@aaqaishtyaq

@aaqaishtyaq aaqaishtyaq commented Jul 20, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

#8349

removed unused parenthesis

https://bugs.python.org/issue34161

@the-knights-who-say-ni

the-knights-who-say-ni commented Jul 20, 2018

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

When your account is ready, please add a comment in this pull request
and a Python core developer will remove the CLA not signed label
to make the bot check again.

Thanks again for your contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jul 20, 2018
@aaqaishtyaq

aaqaishtyaq commented Jul 20, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Need to close #8349.
Also, I've signed the CLA.
Please review @Mariatta

@Mariatta
Mariatta merged commit cb5f3fd into python:master Jul 20, 2018
@miss-islington

miss-islington commented Jul 20, 2018

Copy link
Copy Markdown
Contributor

Thanks @aaqaishtyaq for the PR, and @Mariatta for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 20, 2018
@aaqaishtyaq @miss-islington
Remove extra parentheses in output formatting tutorial (pythonGH-8350)
cf21aa8 
The parentheses were incorrect.
(cherry picked from commit cb5f3fd)

Co-authored-by: Aaqa Ishtyaq <[email protected]>
@bedevere-bot

bedevere-bot commented Jul 20, 2018

Copy link
Copy Markdown

GH-8354 is a backport of this pull request to the 3.7 branch.

@Mariatta

Mariatta commented Jul 20, 2018

Copy link
Copy Markdown
Member

Thanks @aaqaishtyaq and congrats on your first contribution to CPython 🌮

Mariatta pushed a commit that referenced this pull request Jul 20, 2018
@miss-islington @aaqaishtyaq @Mariatta
bpo-34161: Remove extra parentheses in output formatting tutorial (GH…
49abd30 
…-8350)

The parentheses were incorrect.
(cherry picked from commit cb5f3fd)

Co-authored-by: Aaqa Ishtyaq <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mariatta Mariatta Mariatta approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

See More

Successfully merging this pull request may close these issues.

5 participants

@aaqaishtyaq @the-knights-who-say-ni @miss-islington @bedevere-bot @Mariatta