Skip to content

bpo-30869: regrtest: Add .idlerc to saved_test_environment #2614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mlouielu wants to merge 1 commit into from
Closed

bpo-30869: regrtest: Add .idlerc to saved_test_environment #2614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion Lib/test/libregrtest/save_env.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ def __init__(self, testname, verbose=0, quiet=False, *, pgo=False):
'os.environ', 'sys.path', 'sys.path_hooks', '__import__',
'warnings.filters', 'asyncore.socket_map',
'logging._handlers', 'logging._handlerList', 'sys.gettrace',
'sys.warnoptions',
'sys.warnoptions', 'idlerc',
# multiprocessing.process._cleanup() may release ref
# to a thread, so check processes first.
'multiprocessing.process._dangling', 'threading._dangling',
Expand Down Expand Up @@ -253,6 +253,29 @@ def get_warnings_showwarning(self):
def restore_warnings_showwarning(self, fxn):
warnings.showwarning = fxn

def get_idlerc(self):
import pathlib
from idlelib.config import idleConf
idlerc_dir = pathlib.Path(idleConf.GetUserCfgDir())

saved = {}
for filename in idlerc_dir.glob('*'):
with open(filename) as f:
saved[filename] = f.read()
return saved

def restore_idlerc(self, saved):
import pathlib
from idlelib.config import idleConf
idlerc_dir = pathlib.Path(idleConf.GetUserCfgDir())

for filename in idlerc_dir.glob('*'):
support.unlink(filename)

for filename in saved:
with open(filename, 'w') as f:
f.write(saved[filename])

def resource_info(self):
for name in self.resources:
method_suffix = name.replace('.', '_')
Expand Down
24 changes: 24 additions & 0 deletions Lib/test/test_regrtest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -951,6 +951,30 @@ def test_env_changed(self):
self.check_executed_tests(output, [testname], env_changed=testname,
fail_env_changed=True)

def test_env_user_idlerc_changed(self):
code = textwrap.dedent("""
import unittest
from idlelib.config import idleConf

class Tests(unittest.TestCase):
def test_user_idlerc_changed(self):
default = idleConf.GetOption('main', 'Theme', 'default',
type='bool')
idleConf.SetOption('main', 'Theme', 'default',
str(not default))
idleConf.SaveUserCfgFiles()
""")
testname = self.create_test(code=code)

# don't fail by default
output = self.run_tests(testname)
self.check_executed_tests(output, [testname], env_changed=testname)

# fail with --fail-env-changed
output = self.run_tests("--fail-env-changed", testname, exitcode=3)
self.check_executed_tests(output, [testname], env_changed=testname,
fail_env_changed=True)


if __name__ == '__main__':
unittest.main()