bpo-23328 Allow / character in username,password fields in _PROXY envvars. #23973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@orsenthil: Please replace |
Contributor
|
Thanks @orsenthil for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9. |
Contributor
|
Sorry @orsenthil, I had trouble checking out the |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 29, 2020
…honGH-23973) (cherry picked from commit 030a713) Co-authored-by: Senthil Kumaran <[email protected]>
|
GH-23992 is a backport of this pull request to the 3.8 branch. |
Contributor
|
Thanks @orsenthil for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 29, 2020
…honGH-23973) (cherry picked from commit 030a713) Co-authored-by: Senthil Kumaran <[email protected]>
|
GH-23993 is a backport of this pull request to the 3.9 branch. |
miss-islington
added a commit
that referenced
this pull request
Dec 29, 2020
…23973) (cherry picked from commit 030a713) Co-authored-by: Senthil Kumaran <[email protected]>
orsenthil
added a commit
that referenced
this pull request
Dec 29, 2020
…23973) (#23992) (cherry picked from commit 030a713) Co-authored-by: Senthil Kumaran <[email protected]>
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bpo-23328 Allow / character in username,password fields in _PROXY envvars.
When urllib was using _parse_proxy method to read proxies from environ variables, if the env had a username, password component and if those had an un-encoded '/' character, the parsing failed.
This change will not break any existing parsing behavior and is localized to username,password scenarios with '/' character in them.
https://bugs.python.org/issue23328