Skip to content

Conversation

@tiran
Copy link
Member

@tiran tiran commented Jun 17, 2020

Signed-off-by: Christian Heimes [email protected]

https://bugs.python.org/issue40998

Automerge-Triggered-By: GH:tiran

Copy link
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiran
Copy link
Member Author

tiran commented Nov 18, 2020

This PR also addresses a reference leak that was introduced in 86ea581 / GH-13159

@tiran tiran force-pushed the bpo-40998-ubsan-warnings branch from de6090b to 851deb9 Compare November 18, 2020 14:57
@miss-islington
Copy link
Contributor

@tiran: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 07f2ade into python:master Nov 18, 2020
@miss-islington
Copy link
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 18, 2020
Signed-off-by: Christian Heimes <[email protected]>

Automerge-Triggered-By: GH:tiran
(cherry picked from commit 07f2ade)

Co-authored-by: Christian Heimes <[email protected]>
@bedevere-bot
Copy link

GH-23370 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Nov 18, 2020
Signed-off-by: Christian Heimes <[email protected]>

Automerge-Triggered-By: GH:tiran
(cherry picked from commit 07f2ade)

Co-authored-by: Christian Heimes <[email protected]>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
Signed-off-by: Christian Heimes <[email protected]>

Automerge-Triggered-By: GH:tiran
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants