Turn on macOS builds for Travis #1846
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brettcannon, thanks for your PR! By analyzing the history of the files in this pull request, we identified @berkerpeksag, @dstufft and @Mariatta to be potential reviewers. |
Mariatta
approved these changes
May 28, 2017
brettcannon
changed the title
brettcannon
changed the title
Member
|
Hi @brettcannon I think it can be more useful if you 'squash' your commits into one ? |
Member
Author
|
@matrixise why specifically? We squash at merge and so what are you hoping to gain if I do it just for the PR? |
Travis requires that all rules in allow_failures be matched for a build to be optional.
brettcannon
added a commit
to brettcannon/cpython
that referenced
this pull request
Jun 3, 2017
Initially the macOS builds are allowed to fail until such time that they can be determined to be stable and not add an unacceptable amount of time to the overall Travis-passing process. (cherry picked from commit 21c2dd7)
brettcannon
added a commit
to brettcannon/cpython
that referenced
this pull request
Jun 3, 2017
Initially the macOS builds are allowed to fail until such time that they can be determined to be stable and not add an unacceptable amount of time to the overall Travis-passing process. (cherry picked from commit 21c2dd7)
brettcannon
added a commit
to brettcannon/cpython
that referenced
this pull request
Jun 3, 2017
Initially the macOS builds are allowed to fail until such time that they can be determined to be stable and not add an unacceptable amount of time to the overall Travis-passing process. (cherry picked from commit 21c2dd7)
brettcannon
added a commit
to brettcannon/cpython
that referenced
this pull request
Jun 3, 2017
Initially the macOS builds are allowed to fail until such time that they can be determined to be stable and not add an unacceptable amount of time to the overall Travis-passing process.. (cherry picked from commit 21c2dd7)
brettcannon
added a commit
that referenced
this pull request
Jun 3, 2017
brettcannon
added a commit
that referenced
this pull request
Jun 3, 2017
brettcannon
added a commit
that referenced
this pull request
Jun 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.