gh-71652: Make IDLE help source menu entries unique and sorted - #17093
Open
ZackerySpytz wants to merge 1 commit into
Open
gh-71652: Make IDLE help source menu entries unique and sorted#17093ZackerySpytz wants to merge 1 commit into
ZackerySpytz wants to merge 1 commit into
Conversation
taleinat
reviewed
Nov 14, 2019
| self.user_helplist = idleConf.GetAllExtraHelpSourcesList() | ||
| self.set_additional_help_sources() | ||
|
|
||
| def set_additional_help_sources(self): |
Contributor
There was a problem hiding this comment.
IMO this method should also be setting self.user_helplist = idleConf.GetAllExtraHelpSourcesList() rather than assuming it is set elsewhere before it is called.
| Additional help sources may be added here with the Configure IDLE dialog under | ||
| the General tab. See the :ref:`Help sources <help-sources>` subsection below | ||
| for more on Help menu choices. | ||
| Additional help sources |
Contributor
There was a problem hiding this comment.
IMHO giving more details here is counter-productive. That the menu items must be unique and sorted are rather minor, technical details. And I find this sentence to be stating the obvious: "The allowed file types may depend on the system." As for checking things when submitted, users will discover that themselves when using the feature, and I'm really not sure documenting it here is valuable.
hauntsaninja
changed the title
|
This PR is stale because it has been open for 30 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue27465