gh-144748: Make EINTR retry paths honor PyThreadState_SetAsyncExc#144926
Closed
VanshAgarwal24036 wants to merge 1 commit intopython:mainfrom
Closed
gh-144748: Make EINTR retry paths honor PyThreadState_SetAsyncExc#144926VanshAgarwal24036 wants to merge 1 commit intopython:mainfrom
VanshAgarwal24036 wants to merge 1 commit intopython:mainfrom
Conversation
Contributor
Author
|
@vstinner Can you please review it when you are free. |
Member
|
Again, can you WAIT before opening PRs? there was no discussion, I am not even sure it is actually a bug and I am not even sure how it should be fixed. So please, stop it. Interpreter-core related issues are not newcomers friendly and I would appreciate that someone more familiar with the C API and the interpreter tackles those issues. |
Contributor
Author
|
Sorry i will keep it in mind for future to not tackle such issues before discussion. |
Member
|
It is not the first time that I asked you that. So please, do so. Otherwise, we will be forced to restrict the access to the repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that PyThreadState_SetAsyncExc interrupts threads blocked in EINTR retry paths (e.g., time.sleep()) by checking async exceptions in _PyEval_MakePendingCalls. Includes a regression test.
tstate->async_exc#144748