Skip to content

Draft: gh-139103: Use _PyObject_GetMethodStackRef for slot_tp_new #141603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
eendebakpt wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Draft: gh-139103: Use _PyObject_GetMethodStackRef for slot_tp_new #141603

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9ca166c
Use _PyObject_GetMethodStackRef for slot_tp_new
eendebakpt Nov 15, 2025
e684ed9
remove double definition
eendebakpt Nov 15, 2025
28bc351
remove dead code
eendebakpt Nov 15, 2025
1619864
add assert
eendebakpt Nov 15, 2025
b1b9085
Apply suggestions from code review
eendebakpt Nov 15, 2025
1d2ef11
📜🤖 Added by blurb_it.
blurb-it[bot] Nov 16, 2025
b141d27
Apply suggestions from code review
eendebakpt Nov 16, 2025
d8930e0
revert changes to auto-generated file
eendebakpt Nov 16, 2025
ade0709
Merge branch 'main' into namedtuple_stackref
eendebakpt Nov 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Use _PyObject_GetMethodStackRef for slot_tp_new
  • Loading branch information
@eendebakpt
eendebakpt committed Nov 15, 2025
commit 9ca166c171423184e28f74a782dec2bf46b25760
13 changes: 10 additions & 3 deletions Objects/typeobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10852,13 +10852,20 @@ slot_tp_new(PyTypeObject *type, PyObject *args, PyObject *kwds)
PyThreadState *tstate = _PyThreadState_GET();
PyObject *func, *result;

func = PyObject_GetAttr((PyObject *)type, &_Py_ID(__new__));
if (func == NULL) {
_PyCStackRef c_stackref;
_PyThreadState_PushCStackRef(tstate, &c_stackref);
int meth_found = _PyObject_GetMethodStackRef(tstate, (PyObject *)type, &_Py_ID(__new__), &c_stackref.ref);

if (PyStackRef_IsNull(c_stackref.ref)) {
_PyThreadState_PopCStackRef(tstate, &c_stackref);
return NULL;
}
func = PyStackRef_AsPyObjectBorrow(c_stackref.ref);
assert(func != NULL);

result = _PyObject_Call_Prepend(tstate, func, (PyObject *)type, args, kwds);
Py_DECREF(func);
//Py_DECREF(func);
_PyThreadState_PopCStackRef(tstate, &c_stackref);
return result;
}

Expand Down
24 changes: 23 additions & 1 deletion Tools/ftscalingbench/ftscalingbench.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@
import threading
import time
from operator import methodcaller
from typing import NamedTuple
from collections import namedtuple

# The iterations in individual benchmarks are scaled by this factor.
WORK_SCALE = 100
Expand All @@ -38,11 +40,31 @@
in_queues = []
out_queues = []


def register_benchmark(func):
ALL_BENCHMARKS[func.__name__] = func
return func

class Foo(NamedTuple):
x: int


Bar = namedtuple('Bar', ['x'])

@register_benchmark
def typing_namedtuple():
for i in range(1000 * WORK_SCALE):
_ = Foo(x=1)

@register_benchmark
def namedtuple():
for i in range(1000 * WORK_SCALE):
_ = Bar(x=1)

@register_benchmark
def namedtuple():
for i in range(1000 * WORK_SCALE):
_ = Foo(x=1)

@register_benchmark
def object_cfunction():
accu = 0
Expand Down