Skip to content

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Jun 14, 2019

@vstinner
Copy link
Member Author

@hroncok @ned-deily: Would you mind to review this doc change?

@vstinner vstinner requested a review from ned-deily June 14, 2019 16:52
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should also be noted that this affects extension modules in the standard library as well as those produced and installed by third-party packages, like those downloaded from PyPI.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated my PR. Does it look better now?

@vstinner
Copy link
Member Author

I rebased my PR to fix a conflict.

Copy link
Member

@ned-deily ned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My preference remains to not make the flags change at all but, if we must, this documents it adequately, I think. :). Thanks!

@vstinner
Copy link
Member Author

My preference remains to not make the flags change at all

Well, "m" in ABI flags became useless around Python 3.4. I don't see the point of pretending that the "m" ABI is different and then provide two names for the same thing:

  • python3.8 and python3.8m
  • python3.8-config and python3.8m-config
  • man python3.8 and man python3.8m
  • etc.

I'm not sure why, but on Fedora /usr/bin/python3.7 and /usr/bin/python3.7m are two separated files... with the same content (ex: same MD5 sum). Well, it's just 17 KiB each :-) /usr/bin/python3.7-config is a symlink to python3.7m-config.

The change itself is painful for distributors like Red Hat (Fedora, RHEL), but things should be simpler once the change is done.

My long-term goal is to get a single ABI for everything: CPython, PyPy, RustPython, MicroPython, etc. :-) Maybe it's not possible, but at least I would like to move towards this goal!

Overall project: https://pythoncapi.readthedocs.io/

@vstinner vstinner merged commit 7efc526 into python:master Jun 15, 2019
@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@vstinner vstinner deleted the abiflags_m_doc branch June 15, 2019 01:24
@vstinner
Copy link
Member Author

Thanks @ned-deily and @yan12125 for the review ;-)

@bedevere-bot
Copy link

GH-14097 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Jun 15, 2019
(cherry picked from commit 7efc526)

Co-authored-by: Victor Stinner <[email protected]>
Copy link
Contributor

@hroncok hroncok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, sorry for not responding faster

lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants