-
-
Notifications
You must be signed in to change notification settings - Fork 33.9k
bpo-36707: Document "m" removed from sys.abiflags #14090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@hroncok @ned-deily: Would you mind to review this doc change? |
Doc/whatsnew/3.8.rst
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should also be noted that this affects extension modules in the standard library as well as those produced and installed by third-party packages, like those downloaded from PyPI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated my PR. Does it look better now?
|
I rebased my PR to fix a conflict. |
ned-deily
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My preference remains to not make the flags change at all but, if we must, this documents it adequately, I think. :). Thanks!
Well, "m" in ABI flags became useless around Python 3.4. I don't see the point of pretending that the "m" ABI is different and then provide two names for the same thing:
I'm not sure why, but on Fedora /usr/bin/python3.7 and /usr/bin/python3.7m are two separated files... with the same content (ex: same MD5 sum). Well, it's just 17 KiB each :-) /usr/bin/python3.7-config is a symlink to python3.7m-config. The change itself is painful for distributors like Red Hat (Fedora, RHEL), but things should be simpler once the change is done. My long-term goal is to get a single ABI for everything: CPython, PyPy, RustPython, MicroPython, etc. :-) Maybe it's not possible, but at least I would like to move towards this goal! Overall project: https://pythoncapi.readthedocs.io/ |
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
|
Thanks @ned-deily and @yan12125 for the review ;-) |
|
GH-14097 is a backport of this pull request to the 3.8 branch. |
(cherry picked from commit 7efc526) Co-authored-by: Victor Stinner <[email protected]>
hroncok
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, sorry for not responding faster
https://bugs.python.org/issue36707