gh-80848: pdb: restore SIGINT handler in sigint_handler already - #12880
Open
blueyed wants to merge 2 commits into
Open
gh-80848: pdb: restore SIGINT handler in sigint_handler already#12880blueyed wants to merge 2 commits into
blueyed wants to merge 2 commits into
Conversation
Contributor
Author
|
Hmm, this was move/changed in 10e54ae. |
blueyed
force-pushed
the
pdb-sigint-restore
branch
from
April 19, 2019 11:05
7bb2610 to
f8e5042
Compare
blueyed
changed the title
Without this, and additional SIGINT while waiting for the next statement
(e.g. during `time.sleep`) will stop at `sigint_handler`.
With this patch:
> …/t-pdb-sigint-in-sleep.py(10)<module>()
-> sleep()
(Pdb) c
^C
Program interrupted. (Use 'cont' to resume).
^CKeyboardInterrupt
> …/t-pdb-sigint-in-sleep.py(6)sleep()
-> time.sleep(10)
(Pdb)
Without this patch:
> …/t-pdb-sigint-in-sleep.py(10)<module>()
-> sleep()
(Pdb) c
^C
Program interrupted. (Use 'cont' to resume).
^C--Call--
> …/cpython/Lib/pdb.py(188)sigint_handler()
-> def sigint_handler(self, signum, frame):
(Pdb)
blueyed
force-pushed
the
pdb-sigint-restore
branch
from
April 19, 2019 11:11
f8e5042 to
9f316bd
Compare
auvipy
suggested changes
Jun 1, 2019
|
The following commit authors need to sign the Contributor License Agreement: |
|
This PR is stale because it has been open for 30 days with no activity. |
Member
|
@blueyed, please sign the CLA (just click the button and follow instructions). We need this to be able to merge this PR. |
serhiy-storchaka
changed the title
github-actions
Bot
removed
the
stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this, and additional SIGINT while waiting for the next statement
(e.g. during
time.sleep) will stop atsigint_handler.With this patch:
Without this patch:
https://bugs.python.org/issue36667
TODO: