Skip to content

bpo-35730: IDLE - test squeezer reload() by checking load_font() - #11585

Merged
terryjreedy merged 1 commit into
python:masterfrom
taleinat:bpo-35730/fix_test_squeezer_reload
Jan 18, 2019
Merged

bpo-35730: IDLE - test squeezer reload() by checking load_font()#11585
terryjreedy merged 1 commit into
python:masterfrom
taleinat:bpo-35730/fix_test_squeezer_reload

Conversation

@taleinat

@taleinat taleinat commented Jan 17, 2019

Copy link
Copy Markdown
Contributor

This is an alternative solution to PR #11552.

Here, instead of checking that zero_char_width changes, the test just checks that .load_font() is called.

https://bugs.python.org/issue35730

@taleinat
taleinat requested a review from terryjreedy January 17, 2019 07:46
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting merge labels Jan 17, 2019
@taleinat taleinat added skip news type-bug An unexpected behavior, bug, or error labels Jan 17, 2019
@terryjreedy terryjreedy changed the title bpo-35730: fix test_reload() by avoiding checking the actual zero_char_width bpo-35730: IDLE - test squeezer reload() by checking load_font called Jan 18, 2019
@terryjreedy terryjreedy changed the title bpo-35730: IDLE - test squeezer reload() by checking load_font called bpo-35730: IDLE - test squeezer reload() by checking load_font() Jan 18, 2019
@terryjreedy

terryjreedy commented Jan 18, 2019

Copy link
Copy Markdown
Member

Thanks. This should be as dependable as any other 'function called' test. Thanks.

@terryjreedy
terryjreedy merged commit e55cf02 into python:master Jan 18, 2019
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @taleinat for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot

Copy link
Copy Markdown

GH-11601 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 18, 2019
miss-islington added a commit that referenced this pull request Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants