Doc: Be explicit that Pathlib resolve was strict before 3.6. #11316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM. The wording conveys your meaning, so I think it's fine. If you wanted to be a little more formal, you can use |
csabella
approved these changes
Dec 26, 2018
eamanu
approved these changes
Dec 26, 2018
pablogsal
approved these changes
Dec 29, 2018
Member
|
LGTM but I also like @csabella suggestion, although I am fine either way :) |
Contributor
|
Thanks @JulienPalard for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 8, 2019
…H-11316) (cherry picked from commit 1d4b160) Co-authored-by: Julien Palard <[email protected]>
|
GH-13190 is a backport of this pull request to the 3.7 branch. |
miss-islington
added a commit
that referenced
this pull request
May 8, 2019
(cherry picked from commit 1d4b160) Co-authored-by: Julien Palard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From: https://mail.python.org/pipermail/docs/2018-December/038529.html
Not sure about the wording, can a native-english proofread this? :)