Skip to content

gh-80282: Argument Clinic: Add clarifying comment about ASCII docstring limitation #107764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
erlend-aasland merged 2 commits into from
Aug 9, 2023
Merged

gh-80282: Argument Clinic: Add clarifying comment about ASCII docstring limitation #107764

erlend-aasland merged 2 commits into from
Aug 9, 2023

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Aug 8, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Aug 8, 2023
Closed
AlexWaygood
AlexWaygood reviewed Aug 8, 2023
View reviewed changes
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Aug 8, 2023

Thanks, Alex. I will await @terryjreedy's review before landing.

terryjreedy
terryjreedy approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@terryjreedy terryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@erlend-aasland erlend-aasland merged commit 925bbc2 into python:main Aug 9, 2023
@erlend-aasland erlend-aasland deleted the clinic/comments branch August 9, 2023 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erlend-aasland @terryjreedy @AlexWaygood @bedevere-bot