Skip to content

Conversation

@holgi
Copy link
Contributor

@holgi holgi commented Nov 26, 2018

In the output of "python -m venv --h" the "--prompt" flag was missing in the usage description and the optionals arguments section.

https://bugs.python.org/issue35307

In the output of "python -m venv --h" the "--prompt" flag was missing in the usage description and the optionals arguments section
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

Copy link
Member

@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR 👍

@csabella
Copy link
Contributor

@zooba, would you be able to merge this? I was about to open a bug for this when I found an existing issue. Thanks!

@tirkarthi
Copy link
Member

Friendly ping @csabella this can be merged now.

@csabella
Copy link
Contributor

@tirkarthi Thanks for the ping!

@csabella csabella merged commit 3208880 into python:master Feb 22, 2019
@miss-islington
Copy link
Contributor

Thanks @holgi for the PR, and @csabella for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 22, 2019
Document usage of the existing `--prompt` option in the command line help.
(cherry picked from commit 3208880)

Co-authored-by: Holger Frey <[email protected]>
@bedevere-bot
Copy link

GH-11986 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Feb 22, 2019
Document usage of the existing `--prompt` option in the command line help.
(cherry picked from commit 3208880)

Co-authored-by: Holger Frey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants