Skip to content

bpo-35284: Fix the error handling in the compiler's compiler_call() #10625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
serhiy-storchaka merged 3 commits into from
Mar 22, 2019
Merged

bpo-35284: Fix the error handling in the compiler's compiler_call() #10625

serhiy-storchaka merged 3 commits into from
Mar 22, 2019

Conversation

@ZackerySpytz
Copy link
Contributor

@ZackerySpytz ZackerySpytz commented Nov 20, 2018 •
edited by bedevere-bot
Loading

compiler_call() needs to check if an error occurred during the
maybe_optimize_method_call() call.

https://bugs.python.org/issue35284

@ZackerySpytz
bpo-35284: Fix the error handling in the compiler's compiler_call()
85ac372 
compiler_call() needs to check if an error occurred during the
maybe_optimize_method_call() call.
brettcannon
brettcannon reviewed Nov 21, 2018
View reviewed changes
@serhiy-storchaka serhiy-storchaka self-assigned this Nov 22, 2018
@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 3.7 skip news labels Nov 22, 2018
@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Nov 22, 2018

Good catch! 👏 It is hard to notice this error. 🕵️‍♂️ How did you find it?

Do you mind to add a comment to maybe_optimize_method_call() about returning values? And please describe the error in more detail on the tracker.

@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Dec 9, 2018

Ping.

@brettcannon
Copy link
Member

brettcannon commented Dec 14, 2018

@ZackerySpytz just in case you didn't see the "ping" from Serhiy.

@ZackerySpytz
Copy link
Contributor Author

ZackerySpytz commented Dec 14, 2018

I saw it.

@ZackerySpytz
Copy link
Contributor Author

ZackerySpytz commented Mar 21, 2019

Hi, @serhiy-storchaka. Thank you for updating this PR. However, it seems that there is an error in the comment that you added. I will edit the comment.

@serhiy-storchaka serhiy-storchaka merged commit 97f5de0 into python:master Mar 22, 2019
@miss-islington
Copy link
Contributor

miss-islington commented Mar 22, 2019

Thanks @ZackerySpytz for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Mar 22, 2019

Sorry, @ZackerySpytz and @serhiy-storchaka, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 97f5de01adf993aee17dcd26e22ae421d013f372 3.7

ZackerySpytz added a commit to ZackerySpytz/cpython that referenced this pull request Mar 22, 2019
@ZackerySpytz
bpo-35284: Fix the error handling in the compiler's compiler_call(). (p…
ef2f8f1 
…ythonGH-10625)

compiler_call() needs to check if an error occurred during the
maybe_optimize_method_call() call.
(cherry picked from commit 97f5de0)
@bedevere-bot
Copy link

bedevere-bot commented Mar 22, 2019

GH-12496 is a backport of this pull request to the 3.7 branch.

@ZackerySpytz
Copy link
Contributor Author

ZackerySpytz commented Mar 22, 2019

Hi, @serhiy-storchaka. I've created a backport PR for 3.7.

serhiy-storchaka pushed a commit that referenced this pull request Mar 22, 2019
@ZackerySpytz @serhiy-storchaka
bpo-35284: Fix the error handling in the compiler's compiler_call(). (G…
bdb9c49 
…H-10625) (GH-12496)

compiler_call() needs to check if an error occurred during the
maybe_optimize_method_call() call.
(cherry picked from commit 97f5de0)
@serhiy-storchaka serhiy-storchaka removed their assignment Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon brettcannon left review comments

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

Assignees

No one assigned

Labels

skip news type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ZackerySpytz @serhiy-storchaka @brettcannon @miss-islington @bedevere-bot @the-knights-who-say-ni