Skip to content

Navigation Menu

Appearance settings

View all features
- BY COMPANY SIZE
  Enterprises
  Small and medium teams
  Startups
  Nonprofits
- BY USE CASE
  App Modernization
  DevSecOps
  DevOps
  CI/CD
  View all use cases
- BY INDUSTRY
  Healthcare
  Financial services
  Manufacturing
  Government
  View all industries
View all solutions
- EXPLORE BY TOPIC
  AI
  Software Development
  DevOps
  Security
  View all topics
- EXPLORE BY TYPE
  Customer stories
  Events & webinars
  Ebooks & reports
  Business insights
  GitHub Skills
- SUPPORT & SERVICES
  Documentation
  Customer support
  Community forum
  Trust center
  Partners
View all resources
- COMMUNITY
  GitHub SponsorsFund open source developers
- PROGRAMS
  Security Lab
  Maintainer Community
  Accelerator
  GitHub Stars
  Archive Program
- REPOSITORIES
  Topics
  Trending
  Collections
- ENTERPRISE SOLUTIONS
  Enterprise platformAI-powered developer platform
- AVAILABLE ADD-ONS
  GitHub Advanced SecurityEnterprise-grade security features
  Copilot for BusinessEnterprise-grade AI features
  Premium SupportEnterprise-grade 24/7 support
Pricing

Appearance settings

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

Uh oh!

There was an error while loading. Please reload this page.

python / cpython Public

Notifications You must be signed in to change notification settings
Fork 35.2k
Star 74.4k

Code
Issues 5k+
Pull requests 2.5k
Actions
Projects
Security and quality
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Projects
Security and quality
Insights

bpo-35224: PEP 572 Implementation - #10497

#10497

Merged

emilyemorehouse merged 67 commits into

python:masterpython/cpython:masterfrom

emilyemorehouse:pep572emilyemorehouse/cpython:pep572Copy head branch name to clipboard

Jan 24, 2019

Conversation Commits67 (67)Checks Files changed

Merged

bpo-35224: PEP 572 Implementation#10497
emilyemorehouse merged 67 commits into
python:masterfrom
emilyemorehouse:pep572

Commits

Commits on Jan 24, 2019

Add tokenization of :=
emilyemorehouse
committed
11e9898
Add initial usage of := in grammar.
emilyemorehouse
committed
9e9156c
Update Python.asdl to match the grammar updates. Regenerated Include/Python-ast.h and Python/Python-ast.c
emilyemorehouse
committed
6eb766d
Update AST and compiler files in Python/ast.c and Python/compile.c. Basic functionality, this isn't scoped properly
emilyemorehouse
committed
4f42586
Regenerate Lib/symbol.py using `./python Lib/symbol.py`
emilyemorehouse
committed
e049ffa
Tests - Fix failing tests in test_parser.py due to changes in token numbers for internal representation
emilyemorehouse
committed
0b6bd95
Tests - Add simple test for := token
emilyemorehouse
committed
24e95fd
Tests - Add simple tests for named expressions using expr and suite
emilyemorehouse
committed
d31135f
Tests - Update number of levels for nested expressions to prevent stack overflow
emilyemorehouse
committed
e19a900
Update symbol table to handle NamedExpr
emilyemorehouse
committed
aca4858
Update Grammar to allow assignment expressions in if statements.
emilyemorehouse
committed
2c7b01e
Tests - Add additional tests for named expressions in RoundtripLegalSyntaxTestCase, based on examples and information directly from PEP 572
emilyemorehouse
committed
f0dad89
Tests - Add temporary syntax test failure tests in test_parser.py
emilyemorehouse
committed
fbea15f
Add support for allowing assignment expressions as function argument annotations. Uncomment tests for these cases because they all pass now!
emilyemorehouse
committed
3cd271b
Tests - Move existing syntax tests out of test_parser.py and into test_named_expressions.py. Refactor syntax tests to use unittest
emilyemorehouse
committed
7b34033
Add TargetScopeError exception to extend SyntaxError
emilyemorehouse
committed
13671f7
Tests - Update tests per PEP 572
emilyemorehouse
committed
5e4ba89
Documentation - Small updates to XXX/todo comments
emilyemorehouse
committed
c1c76ea
Fix assert in seq_for_testlist()
emilyemorehouse
committed
0ebccb4
Cleanup - Denote "Not implemented -- No keyword args" on failing test case. Fix PEP8 error for blank lines at beginning of test classes in test_parser.py
emilyemorehouse
committed
5500849
Tests - Wrap all file opens in `with...as` to ensure files are closed
emilyemorehouse
committed
38dfaa2
WIP: handle f(a := 1)
emilyemorehouse
committed
3aaddc4
Tests and Cleanup - No longer skips keyword arg test. Keyword arg test now uses a simpler test case and does not rely on an external file. Remove print statements from ast.c
emilyemorehouse
committed
5d525a9
Tests - Refactor last remaining test case that relied on on external file to use a simpler test case without the dependency
emilyemorehouse
committed
32dc443
Tests - Add better description of remaning skipped tests. Add test checking scope when using assignment expression in a function argument
emilyemorehouse
committed
d806088
Tests - Add test for nested comprehension, testing value and scope. Fix variable name in skipped comprehension scope test
emilyemorehouse
committed
c1469bf
Handle restriction of LHS for named expressions - can only assign to LHS of type NAME. Specifically, restrict assignment to tuples
emilyemorehouse
committed
e4e63ed
Tests - Update negative test case for assigning to lambda to match new error message. Add negative test case for assigning to tuple
emilyemorehouse
committed
db936c7
Tests - Reorder test cases to group invalid syntax cases and named assignment target errors
emilyemorehouse
committed
47e7367
Tests - Update test case for named expression in function argument - check that result and variable are set correctly
emilyemorehouse
committed
787068e
Todo - Add todo for TargetScopeError based on Guido's comment (https://github.com/python/cpython/commit/2b3acd37bdfc2d35e5094228c6684050d2aa8b0a#r30472562)
emilyemorehouse
committed
e21f5c8
Tests - Add named expression tests for assignment operator in function arguments
emilyemorehouse
committed
acd0f74
Add NamedStore to expr_context. Regenerate related code with `make regen-ast`
emilyemorehouse
committed
d0dd983
Add usage of NamedStore to ast_for_named_expr in ast.c. Update occurances of checking for Store to also handle NamedStore where appropriate
emilyemorehouse
committed
9b136d9
Add ste_comprehension to _symtable_entry to track if the namespace is a comprehension. Initialize ste_comprehension to 0. Set set_comprehension to 1 in symtable_handle_comprehension
emilyemorehouse
committed
8fc5c99
s/symtable_add_def/symtable_add_def_helper. Add symtable_add_def to handle grabbing st->st_cur and passing it to symtable_add_def_helper. This now allows us to call the original code from symtable_…
emilyemorehouse
committed
538dea4
Refactor symtable_record_directive to take lineno and col_offset as arguments instead of stmt_ty. This allows symtable_record_directive to be used for stmt_ty and expr_ty
emilyemorehouse
committed
ab34b0b
Handle elevating scope for named expressions in comprehensions.
emilyemorehouse
committed
c04a08d
Handle error for usage of named expression inside a class block
emilyemorehouse
committed
f0297f8
Tests - No longer skip scope tests. Add additional scope tests
emilyemorehouse
committed
ee6d789
Cleanup - Update error message for named expression within a comprehension within a class. Update comments. Add assert for symtable_extend_namedexpr_scope to validate that we always find at least a…
emilyemorehouse
committed
c37e3c1
Cleanup - Add missing case for NamedStore in expr_context_name. Remove unused var in set_namedexpr_content
emilyemorehouse
committed
1db3fa9
Refactor - Consolidate set_context and set_namedexpr_context to reduce duplicated code. Special cases for named expressions are handled by checking if ctx is NamedStore
emilyemorehouse
committed
0e29038
Cleanup - Add additional use cases for ast_for_namedexpr in usage comment. Fix multiple blank lines in test_named_expressions
emilyemorehouse
committed
2ff5744
Tests - Remove unnecessary test case. Renumber test case function names
emilyemorehouse
committed
2494008
Remove TargetScopeError for now. Will add back if needed
emilyemorehouse
committed
794a1d1
Cleanup - Small comment nit for consistency
emilyemorehouse
committed
415d469
Handle positional argument check with named expression
emilyemorehouse
committed
162c8c4
Add TargetScopeError exception definition. Add documentation for TargetScopeError in c-api docs. Throw TargetScopeError instead of SyntaxError when using a named expression in a comprehension withi…
emilyemorehouse
committed
68e9e98
Increase stack size for parser by 200. This is a minimal change (approx. 5kb) and should not have an impact on any systems. Update parser test to allow 99 nested levels again
emilyemorehouse
committed
1ad4b30
Add TargetScopeError to exception_hierarchy.txt for test_baseexception.py_
emilyemorehouse
committed
1b1d84d
Tests - Major update for named expression tests, both in test_named_expressions and test_parser
emilyemorehouse
committed
b80108b
Cleanup - Remove unnecessary comment
emilyemorehouse
committed
6e15f5f
Cleanup - Comment nitpicks
emilyemorehouse
committed
da11136
Explicitly disallow assignment expressions to a name inside parentheses, e.g.: ((x) := 0)
emilyemorehouse
committed
051ad8c
Cleanup - Wrap lines more strictly in test file
emilyemorehouse
committed
f893035
Revert "Explicitly disallow assignment expressions to a name inside parentheses, e.g.: ((x) := 0)"
emilyemorehouse
committed
16d7137
Add NEWS.d entry
emilyemorehouse
committed
070983b
Tests - Fix error in test_pickle.test_exceptions by adding TargetScopeError to list of exceptions
emilyemorehouse
committed
5133800
Tests - Update error message tests to reflect improved messaging convention (s/can't/cannot)
emilyemorehouse
committed
bc2fed3
Remove cases that cannot be reached in compile.c. Small linting update.
emilyemorehouse
committed
f1cabf8
Update Grammar/Tokens to add COLONEQUAL. Regenerate all files
emilyemorehouse
committed
0e0ca07
Update TargetScopeError PRE_INIT and POST_INIT, as this was purposefully left out when fixing rebase conflicts
emilyemorehouse
committed
1153aae
Add NamedStore back and regenerate files
emilyemorehouse
committed
7775b0d
Pass along line number and end col info for named expression
emilyemorehouse
committed
10a71f8
Simplify News entry
emilyemorehouse
committed
2b9a7bc
Fix compiler warning and explicity mark fallthrough
emilyemorehouse
committed
a63bf06

Footer

© 2026 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Community
Docs
Contact

You can’t perform that action at this time.