Fix duplicate END check in ComponentPascalLexer.analyse_text#3032
Open
daniel7an wants to merge 1 commit intopygments:masterfrom
Open
Fix duplicate END check in ComponentPascalLexer.analyse_text#3032daniel7an wants to merge 1 commit intopygments:masterfrom
daniel7an wants to merge 1 commit intopygments:masterfrom
Conversation
The analyse_text method checked for 'END' twice, making the second check redundant. Replace the duplicate with 'MODULE', which is another common Component Pascal keyword (programs are wrapped in MODULE...END). Fixes pygments#3028
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the duplicate
'END' in textcheck inComponentPascalLexer.analyse_text.Problem
The
analyse_textmethod checks for'END'twice (lines 114 and 118), making the second check redundant. This means the method awards +0.02 forENDbut only +0.01 forBEGINandPROCEDURE, which is unintentional.Fix
Replace the second
'END'check with'MODULE', since Component Pascal programs are structured asMODULE ... ENDblocks, making it a natural and distinctive keyword to check for.Fixes #3028