Skip to content

DEV/CI: use Pixi for examples, notebooks, and xp-tests#922

Merged
hameerabbasi merged 12 commits intopydata:mainfrom
lucascolley:more-pixi
Feb 5, 2026
Merged

DEV/CI: use Pixi for examples, notebooks, and xp-tests#922
hameerabbasi merged 12 commits intopydata:mainfrom
lucascolley:more-pixi

Conversation

@lucascolley
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • 💾 Refactor
  • 🪄 Feature
  • 🐞 Bug Fix
  • 🔧 Optimization
  • 📚 Documentation
  • 🧪 Test
  • 🛠️ Other

Related issues

  • Related issue #
  • Closes #

Checklist

  • Code follows style guide
  • Tests added
  • Documented the changes

Please explain your changes below.

@lucascolley lucascolley changed the title WIP: Pixi for examples and notebooks WIP: Pixi for examples, notebooks, and xp-tests Feb 4, 2026
Comment on lines +22 to +23
os.environ[sparse._ENV_VAR_NAME] = "Numba"
importlib.reload(sparse)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

locally, L45/47 failed due to finch tensor input and Numba backend

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, might be due to the -n 4 on the notebooks example.

@lucascolley lucascolley changed the title WIP: Pixi for examples, notebooks, and xp-tests DEV/CI: use Pixi for examples, notebooks, and xp-tests Feb 4, 2026
@lucascolley lucascolley marked this pull request as ready for review February 4, 2026 22:59
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 4, 2026

CodSpeed Performance Report

Merging this PR will improve performance by 47.11%

Comparing lucascolley:more-pixi (fc732a8) with main (e0816bf)

Summary

⚡ 2 improved benchmarks
✅ 338 untouched benchmarks

Performance Changes

Benchmark BASE HEAD Efficiency
test_index_fancy[side=100-rank=1-format='coo'] 964.1 µs 752.9 µs +28.05%
test_index_slice[side=100-rank=2-format='gcxs'] 2.7 ms 1.9 ms +47.11%

Copy link
Collaborator Author

@lucascolley lucascolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finch array API tests — on main:

= 190 failed, 787 passed, 39 skipped, 215 xfailed, 50942 warnings in 2027.44s (0:33:47) =

on this PR:

= 56 failed, 899 passed, 85 skipped, 51 xfailed, 136 xpassed, 1079 warnings in 103.60s (0:01:43) =

not sure what is causing the difference?

@hameerabbasi
Copy link
Collaborator

Cool! Could you also update CONTRIBUTING.md?

@hameerabbasi
Copy link
Collaborator

Finch array API tests — on main:

= 190 failed, 787 passed, 39 skipped, 215 xfailed, 50942 warnings in 2027.44s (0:33:47) =

on this PR:

= 56 failed, 899 passed, 85 skipped, 51 xfailed, 136 xpassed, 1079 warnings in 103.60s (0:01:43) =

not sure what is causing the difference?

Looks like the Finch env isn't getting activated.

https://github.com/pydata/sparse/actions/runs/21691731277/job/62552909075?pr=922#step:4:4794

Looks like the env var isn't getting set at all. It's using COO, which doesn't exist in the Finch backend.

@lucascolley
Copy link
Collaborator Author

Cool! Could you also update CONTRIBUTING.md?

84f7700 (#922)

@lucascolley
Copy link
Collaborator Author

lucascolley commented Feb 5, 2026

do you know why the CI job was just cancelled @hameerabbasi ?

@hameerabbasi
Copy link
Collaborator

do you know why the CI job was just cancelled @hameerabbasi ?

There were some issues with GitHub notifications yesterday. I assume this was just an outage.

Copy link
Collaborator

@hameerabbasi hameerabbasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch, @lucascolley!

@lucascolley
Copy link
Collaborator Author

It just happened again now, though

@hameerabbasi
Copy link
Collaborator

hameerabbasi commented Feb 5, 2026

It just happened again now, though

WDYM? The job shows as a success. https://github.com/pydata/sparse/actions/runs/21710631353/job/62613266192?pr=922

Also for the last few commits.

@hameerabbasi hameerabbasi merged commit 5ad6d04 into pydata:main Feb 5, 2026
12 of 14 checks passed
@lucascolley
Copy link
Collaborator Author

@hameerabbasi
Copy link
Collaborator

https://github.com/pydata/sparse/actions/runs/21710631353/job/62613266174

The xp-tests-finch job

Hmm, the cancellation is new, might be due to commits being pushed one after another. The job has been red for quite some time though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants