CHG: the PartitionedApproximateHasher base class now handles the hashing of partitions
#31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbrugman
force-pushed
the
refactor-partitions
branch
from
35d9042 to
97786f3
Compare
RUrlus
approved these changes
Dec 4, 2023
…shing of partitions Subclasses now only need an `ApproximateHasher` instance and to return the partition names
sbrugman
force-pushed
the
refactor-partitions
branch
from
97786f3 to
46f61f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subclasses now only need an
ApproximateHasherinstance and to return the partition namesDepends on #30