Skip to content

ENH: improved handling of unsupported built-in functions #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
RUrlus merged 10 commits into from
Dec 1, 2023
Merged

ENH: improved handling of unsupported built-in functions #23

RUrlus merged 10 commits into from
Dec 1, 2023

Conversation

@RUrlus
Copy link
Collaborator

@RUrlus RUrlus commented Nov 30, 2023 •
edited
Loading

Changes

  • CHG: Whitelist handled rope types rather than blacklist unhandled types
  • CHG: Separate exception for for functions for which we cannot find a location but are not Builtin's
  • CHG: Make project creation an explicit call
  • CHG: Explicitly restrict location lookup to first-party modules

Enhancements

Chores

  • CICD: Install reference packages in test image

@RUrlus RUrlus requested a review from sbrugman November 30, 2023 10:03
@RUrlus RUrlus changed the title FIX: Catch and handle builtin function hashes ENH: improved handling of unsupported built-in functions Nov 30, 2023
@RUrlus RUrlus force-pushed the bug_bunny branch 4 times, most recently from c577ec2 to f12abdc Compare November 30, 2023 10:45
sbrugman
sbrugman reviewed Nov 30, 2023
View reviewed changes
@sbrugman sbrugman mentioned this pull request Nov 30, 2023
Merged
sbrugman
sbrugman reviewed Nov 30, 2023
View reviewed changes
@RUrlus RUrlus marked this pull request as draft November 30, 2023 14:09
@RUrlus RUrlus force-pushed the bug_bunny branch 5 times, most recently from 8c29c28 to 7b157d5 Compare December 1, 2023 13:57
@RUrlus RUrlus marked this pull request as ready for review December 1, 2023 17:43
sbrugman
sbrugman reviewed Dec 1, 2023
View reviewed changes
sbrugman
sbrugman reviewed Dec 1, 2023
View reviewed changes
sbrugman
sbrugman reviewed Dec 1, 2023
View reviewed changes
@sbrugman
Copy link
Collaborator

sbrugman commented Dec 1, 2023

The commit conventions in CONTRIBUTING.md are missing CHG, FIX and CICD.
Would be good to update them there.

@RUrlus RUrlus merged commit 2a34277 into main Dec 1, 2023
@RUrlus RUrlus deleted the bug_bunny branch December 1, 2023 20:01
@sbrugman sbrugman added the enhancement New feature or request label Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbrugman sbrugman sbrugman approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cannot hash builtin functions

3 participants

@RUrlus @sbrugman