This repository was archived by the owner on Nov 4, 2020. It is now read-only.
Add search kwarg to getgroups as this is actually supported by the gitlab api#124
Closed
ohcibi wants to merge 1 commit into
Closed
Add search kwarg to getgroups as this is actually supported by the gitlab api#124ohcibi wants to merge 1 commit into
getgroups as this is actually supported by the gitlab api#124ohcibi wants to merge 1 commit into
Conversation
Author
|
This does not work as expected.. Sorry for bothering... |
Contributor
|
What was wrong with this? I just cloned your change and tried it on our Gitlab instance (v8.1.3 ee), and it seems to be working as expected. I think your tests failed because of a typo. Or am I missing something? |
Author
|
tbh I don't know anymore why I wrote that this does not work as expected. I'm also seeing that obvious typo now. I think I never ran the tests locally because I didn't actually setup the test environment with creating a db and stuff. I'll re-pr this, because I cannot reopen as I have already force-pushed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.