Skip to content

Assert allclose correction (#630)#631

Closed
CameronTStark wants to merge 0 commit intopvlib:masterfrom
CameronTStark:assert_allclose_correction
Closed

Assert allclose correction (#630)#631
CameronTStark wants to merge 0 commit intopvlib:masterfrom
CameronTStark:assert_allclose_correction

Conversation

@CameronTStark
Copy link
Copy Markdown
Contributor

@CameronTStark CameronTStark commented Dec 7, 2018

  • Closes issue atol parameter too wide for assert_allclose() in test_pvsystem.py #630
  • I am familiar with the contributing guidelines.
  • Fully tested. Added and/or modified tests to ensure correct behavior for all reasonable inputs. Tests (usually) must pass on the TravisCI and Appveyor testing services.
  • Updates entries to docs/sphinx/source/api.rst for API changes.
  • Adds description and name entries in the appropriate docs/sphinx/source/whatsnew file for all changes.
  • Code quality and style is sufficient. Passes LGTM and SticklerCI checks.
  • New code is fully documented. Includes sphinx/numpydoc compliant docstrings and comments in the code where necessary.
  • Pull request is nearly complete and ready for detailed review.

@stickler-ci
Copy link
Copy Markdown

stickler-ci bot commented Dec 7, 2018

Could not review pull request. It may be too large, or contain no reviewable changes.

@CameronTStark
Copy link
Copy Markdown
Contributor Author

CameronTStark commented Dec 7, 2018

Tried to PR a branch with an unmerged PR in it. Went back and corrected it to the right commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@CameronTStark