Conversation
fsoikin
reviewed
Apr 28, 2022
fsoikin
reviewed
Apr 28, 2022
|
|
||
| build-example: $(OUTPUT) | ||
| pulp build -I example --to $(OUTPUT)/example.js | ||
| npx spago bundle-app --path $(example) --to $(OUTPUT)/example.js --minify |
Member
There was a problem hiding this comment.
Isn't bundling functionality going away?
Collaborator
Author
There was a problem hiding this comment.
Native bundling is going away, and instead Spago will call out to esbuild under the hood (if it's installed), or you can swap in another bundler.
Collaborator
Author
|
@fsoikin I seem to have busted something related to the |
fsoikin
reviewed
Apr 28, 2022
Co-authored-by: Fyodor Soikin <[email protected]>
Collaborator
Author
|
This should be good to go pending felixSchl/purescript-pipes#21 |
Collaborator
Author
|
@fsoikin this is now ready for review, if you'd like! |
Member
|
Cut and published v7.0.0, thanks @thomashoneyman! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes a number of updates so the library will be compatible with all the other PureScript 0.15 library releases.