Conversation
There was a problem hiding this comment.
Why do we use the pulp.deve.test_runner and not just call nosetests directly?
There was a problem hiding this comment.
I used it here just because it is used everywhere else. I think the original reason we made it was that it made it easier to skip tests on EL 5. Admittedly, this plugin may never support EL 5 though I am not sure. I do plan to make consumer functions for it so you can tell a client to pip install things. It's possible that it might work on EL 5.
https://github.com/pulp/pulp/blob/master/devel/pulp/devel/test_runner.py
|
LGTM |
|
Actually there is one issue that needs to be fixed. There is a leftover file that is preventing HTTPD from starting when this is installed. The file path is: pulp_python/plugins/etc/httpd/conf.d/pulp_ostree.conf I expected it to be: pulp_python/plugins/etc/httpd/conf.d/pulp_python.conf |
fixes according to comments in pull request pulp#121
2 participants
This PR brings the pulp_python repo into a state of passing unit and flake8 tests.