Skip to content

Fix "Implicitly marking parameter ... as nullable is deprecated, the explicit nullable type must be used instead"#20

Open
rvdsteege wants to merge 1 commit intopronamic:mainfrom
rvdsteege:fix-implicitly-marking-parameter-nullable
Open

Fix "Implicitly marking parameter ... as nullable is deprecated, the explicit nullable type must be used instead"#20
rvdsteege wants to merge 1 commit intopronamic:mainfrom
rvdsteege:fix-implicitly-marking-parameter-nullable

Conversation

@rvdsteege
Copy link
Member

@rvdsteege rvdsteege commented Oct 10, 2025

This PR resolves the below error messages, which I noticed when building docs for https://github.com/pronamic/wp-pay-core/:

PHP Deprecated:  Pronamic\WordPress\Documentor\Argument::set_param_tag(): Implicitly marking parameter $param_tag as nullable is deprecated, the explicit nullable type must be used instead in /vendor/pronamic/wp-documentor/src/Argument.php on line 83
PHP Deprecated:  Pronamic\WordPress\Documentor\Hook::set_doc_comment(): Implicitly marking parameter $doc_comment as nullable is deprecated, the explicit nullable type must be used instead in /vendor/pronamic/wp-documentor/src/Hook.php on line 133
PHP Deprecated:  Pronamic\WordPress\Documentor\Hook::set_changelog(): Implicitly marking parameter $changelog as nullable is deprecated, the explicit nullable type must be used instead in /vendor/pronamic/wp-documentor/src/Hook.php on line 289

@rvdsteege
Fix "Implicitly marking parameter ... as nullable is deprecated, the …
a3562a8 
…explicit nullable type must be used instead"
@gemini-code-assist
Copy link

gemini-code-assist bot commented Oct 10, 2025

Summary of Changes

Hello @rvdsteege, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses PHP 8.1+ deprecation warnings by updating method signatures to explicitly declare nullable types for parameters that have a default null value. This ensures compatibility with newer PHP versions and prevents deprecation notices during documentation generation.

Highlights

  • PHP Deprecation Fix: Explicitly typed nullable parameters in set_param_tag, set_doc_comment, and set_changelog methods to resolve PHP 8.1+ deprecation warnings regarding implicitly nullable parameters.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Oct 10, 2025
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly resolves the PHP deprecation warnings by updating method signatures to use explicit nullable types. The changes are accurate and improve compatibility with modern PHP versions. I have included one suggestion to improve code readability and consistency by importing a class instead of using its fully qualified name. Overall, this is a solid and necessary update.

src/Hook.php
* @param \PhpParser\Comment\Doc|null $doc_comment Doc comment.
*/
public function set_doc_comment( \PhpParser\Comment\Doc $doc_comment = null ) {
public function set_doc_comment( ?\PhpParser\Comment\Doc $doc_comment = null ) {
Copy link

@gemini-code-assist gemini-code-assist bot Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While functionally correct, using the fully qualified class name \PhpParser\Comment\Doc here is verbose and inconsistent with how other classes (like SplFileInfo) are handled in this file. For better readability and consistency, I suggest importing PhpParser\Comment\Doc at the top of the file and using ?Doc in the signature. This would make the code cleaner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@rvdsteege