Add visual tests for blendMode() across renderers#1440
Add visual tests for blendMode() across renderers#1440catilac merged 2 commits intoprocessing:visual-testingfrom
Conversation
|
Hey @mingness, PR is up BlendModeTest covers the 10 modes + one that switches mid-sketch to make sure nothing leaks between mode changes. Using JAVA2D, baselines are Windows. Tests green locally. |
|
@Vaivaswat2244 may I ask you to review this one? :) |
|
Hey @avinxshKD, thanks a lot for your work on this. |
|
Hey @catilac @Vaivaswat2244 added the comments, kept it minimal, just a one-liner on the helper explaining the test scene setup, a note on why BLEND gets called before the actual mode under test (that one was genuinely non-obvious), and a line in testModeSwitch saying what it's checking for. nothing structural changed lmk if any changes needed |
|
Hey @catilac once I have my GSoC proposal ready would you be okay with taking a look at it? |
|
Hi @avinxshKD , thanks for your enthusiasm for participating in GSoC with the Processing Foundation. We're committed to keeping the process open and fair, so I encourage you to participate in the Q&A part of the process, where you will be able to ask questions about the projects and applications in an open forum. We can't really provide one-on-one advice on applications - it creates a conflict of interest situation which in the end would not be good for your application, and we want you to have a fair shot at the spots. Looking forward to your application! |
| @Test | ||
| @Order(11) | ||
| @DisplayName("Switching blend modes mid-sketch") | ||
| public void testModeSwitch() { |
There was a problem hiding this comment.
testModeSwitch is the only test that doesn't go through createBlendTest, meaning its background setup lives in a separate code path.
This is fine for now, but createBlendTest also hardcodes background(128) and noStroke() — so if those defaults ever change, testModeSwitch will silently drift out of sync. Worth either routing it through a shared base or leaving a comment that these need to be kept in step with the createBLendTest
There was a problem hiding this comment.
@Vaivaswat2244 would you be able to make an issue documenting this?
|
Hey @mingness thanks for the clarification, I wasn’t aware of the one-on-one feedback constraint. My bad |
|
@avinxshKD thanks! Also keep in mind that GSoC is to help facilitate new contributors to open source, so don't contribute too much 😆 I recommend to spend your time crafting your proposal. We are looking for thoughtful proposals that show awareness for the needs of the codebase, that leverage your existing experience, and also that address your own interests. Thanks for this work! |
|
Hey @mingness thanks, this is really helpful. I’m already deep into the proposal and grounding it in what the project actually needs. Im focusing my time there and making sure what I submit is concrete and worth reviewing. Thanks again for the clear guidance |
|
Thanks so much @avinxshKD @Vaivaswat2244 ! going to merge it in |
4 participants
Added BlendModeTest covering all 10 blend modes (BLEND, ADD, SUBTRACT, MULTIPLY, SCREEN, DARKEST, LIGHTEST, DIFFERENCE, EXCLUSION, REPLACE) plus one test that switches modes mid-sketch. Using JAVA2D for now since per-renderer baseline support isn't figured out yet. Windows baselines included, all 11 tests pass locally
Closes #1434