Skip to content

Fix locked issue crash + robustness changes #6308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SableRaf merged 1 commit into from
Jul 15, 2026
+90 −52
Merged

Fix locked issue crash + robustness changes #6308

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
142 changes: 90 additions & 52 deletions .github/workflows/lock.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ on:
- cron: '0 6 * * *'
workflow_dispatch:

concurrency:
group: close-old-threads
cancel-in-progress: false

permissions:
issues: write
pull-requests: write
Expand All @@ -23,23 +27,48 @@ jobs:
const cutoff = new Date();
cutoff.setDate(cutoff.getDate() - cutoffDays);

const closeIssueMessage = `This issue has been automatically closed and locked.

Processing 3.x is no longer actively developed. Since January 2020, development moved to the Processing 4 repository.

If this issue is still relevant to Processing 4, we'd love to hear from you. Please open a new issue at:
https://github.com/processing/processing4/issues/new/choose

Thank you for helping improve Processing.`;

const closePrMessage = `This pull request has been automatically closed and locked.

Processing 3.x is no longer actively developed. Since January 2020, development moved to the Processing 4 repository.

If you'd still like to contribute this work, please open an issue in the Processing 4 repository to discuss it first:
https://github.com/processing/processing4/issues/new/choose
const closeIssueMessage = [
'This issue has been automatically closed and locked.',
'',
'Processing 3.x is no longer actively developed. Since January 2020, development moved to the Processing 4 repository.',
'',
"If this issue is still relevant to Processing 4, we'd love to hear from you. Please open a new issue at:",
'https://github.com/processing/processing4/issues/new/choose',
'',
'Thank you for helping improve Processing.'
].join('\n');

const closePrMessage = [
'This pull request has been automatically closed and locked.',
'',
'Processing 3.x is no longer actively developed. Since January 2020, development moved to the Processing 4 repository.',
'',
"If you'd still like to contribute this work, please open an issue in the Processing 4 repository to discuss it first:",
'https://github.com/processing/processing4/issues/new/choose',
'',
'Thank you for your contribution.'
].join('\n');

async function closeThread(thread) {
const isPr = Boolean(thread.pull_request);

Thank you for your contribution.`;
if (isPr) {
await github.rest.pulls.update({
owner: context.repo.owner,
repo: context.repo.repo,
pull_number: thread.number,
state: 'closed'
});
} else {
await github.rest.issues.update({
owner: context.repo.owner,
repo: context.repo.repo,
issue_number: thread.number,
state: 'closed',
state_reason: 'not_planned'
});
}
}

const threads = await github.paginate(github.rest.issues.listForRepo, {
owner: context.repo.owner,
Expand All @@ -51,41 +80,50 @@ jobs:
});

for (const thread of threads) {
const updatedAt = new Date(thread.updated_at);

if (updatedAt > cutoff) {
continue;
}

const labels = thread.labels.map(label => label.name);
const isExempt = labels.some(label => exemptLabels.includes(label));

if (isExempt) {
continue;
try {
const updatedAt = new Date(thread.updated_at);

if (updatedAt > cutoff) {
break;
}

const labels = thread.labels.map(label =>
typeof label === 'string' ? label : label.name
);

const isExempt = labels.some(label => exemptLabels.includes(label));

if (isExempt) {
console.log(`Skipping #${thread.number}: exempt label.`);
continue;
}

const isPr = Boolean(thread.pull_request);
const body = isPr ? closePrMessage : closeIssueMessage;

await closeThread(thread);

if (thread.locked) {
console.log(`Closed #${thread.number}: already locked, so no comment was added.`);
continue;
}

await github.rest.issues.createComment({
owner: context.repo.owner,
repo: context.repo.repo,
issue_number: thread.number,
body
});

await github.rest.issues.lock({
owner: context.repo.owner,
repo: context.repo.repo,
issue_number: thread.number,
lock_reason: 'resolved'
});

console.log(`Closed and locked #${thread.number}.`);
} catch (error) {
console.log(`Failed on #${thread.number}: ${error.status || 'unknown status'} ${error.message}`);
}

const isPr = Boolean(thread.pull_request);
const body = isPr ? closePrMessage : closeIssueMessage;

await github.rest.issues.createComment({
owner: context.repo.owner,
repo: context.repo.repo,
issue_number: thread.number,
body
});

await github.rest.issues.update({
owner: context.repo.owner,
repo: context.repo.repo,
issue_number: thread.number,
state: 'closed',
state_reason: 'not_planned'
});

await github.rest.issues.lock({
owner: context.repo.owner,
repo: context.repo.repo,
issue_number: thread.number,
lock_reason: 'resolved'
});
}