Fix locked issue crash + robustness changes - #6308
Merged
Merged
Conversation
> [!NOTE] > this needs testing against the actual repository. This PR fixes the following issue: `Error: Unhandled error: HttpError: Unable to create comment because issue is locked.` See: https://github.com/processing/processing/actions/runs/29001253630 #### Summary of changes: - Skips commenting/locking on threads that are already locked (fixes the `HttpError: Unable to create comment because issue is locked` crash) - Wraps per-thread processing in try/catch so one failure doesn't abort the whole run - Closes PRs via `pulls.update` instead of `issues.update` - Adds a `concurrency` group to prevent overlapping runs - Handles labels returned as plain strings, not just objects - Breaks out of the loop once a thread is newer than the cutoff (list is already sorted) instead of just `continue` - Builds close messages via array + `join('\n')` instead of a template literal (avoids leading-whitespace indentation in the posted comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
this needs testing against the actual repository.
This PR fixes:
Error: Unhandled error: HttpError: Unable to create comment because issue is locked.See action log: https://github.com/processing/processing/actions/runs/29001253630
Summary of changes:
pulls.updateinstead ofissues.updateconcurrencygroup to prevent overlapping runscontinuejoin('\n')instead of a template literal (avoids leading-whitespace indentation in the posted comment)