Skip to content

Discrepancy between listed semantic PR titles and those approved by PR bot #72

@matthewfeickert

Description

@matthewfeickert

Hi. We use the Semantic Pull Request bot on our project pyhf. However, we've noticed that the bot doesn't recognize PRs that start with the improvement keyword as being semantic (examples: pyhf PR 596 and PR 541) though it is listed in the link off of the README to commitizen/conventional-commit-types

PR title is semantic

I see that this is because improvement was added to commitizen/conventional-commit-types less than 2 weeks ago in their PR 13 and the Semantic Pull Request bot uses v2.2.0 of commitizen/conventional-commit-types — which was released in 2017.

I just wanted to report this, but I guess I should also ask if you plan on only supporting the types that are in releases of commitizen/conventional-commit-types. If so, I guess I should bug them RE: the possibility of a new release in 2019.

cc @kratsg @lukasheinrich

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions