fix checking for parseShadowDom option#767
Open
tstackhouse wants to merge 1 commit intoprerender:masterfrom
Open
fix checking for parseShadowDom option#767tstackhouse wants to merge 1 commit intoprerender:masterfrom
tstackhouse wants to merge 1 commit intoprerender:masterfrom
Conversation
nickdemarco89
approved these changes
Oct 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been testing using this against our new website which uses shadowdom for some of our content, however I found that the
parseShadowDomoption isn't actually being set on thetab.prerenderobject. By adding the check below we get the shadowdom content in the prerendered response.