Enforce that the main/module/browser/umd:main fields are not present when using the "type": "module" mode - #615
Merged
Conversation
…when "type": "module" mode
🦋 Changeset detectedLatest commit: 6a08217 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #615 +/- ##
==========================================
+ Coverage 92.53% 92.55% +0.02%
==========================================
Files 39 39
Lines 2089 2096 +7
Branches 645 661 +16
==========================================
+ Hits 1933 1940 +7
Misses 145 145
Partials 11 11 ☔ View full report in Codecov by Sentry. |
emmatown
commented
Feb 24, 2025
| if (pkg.isTypeModule()) { | ||
| keys(fields).forEach((field) => { | ||
| if (fields[field]) { | ||
| delete (pkg.json as any)[field]; |
Member
Author
There was a problem hiding this comment.
Note this is done on pkg instead of the pkg.entrypoints since the entrypoint package.jsons(besides the package's one itself) are removed automatically already elsewhere
Andarist
approved these changes
Feb 24, 2025
emmatown
deleted the
remove-main-module-fields-when-using-type-module
branch
February 25, 2025 03:41
Merged
emmatown
restored the
remove-main-module-fields-when-using-type-module
branch
November 22, 2025 01:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref changesets/changesets#1482 (comment)