Skip to content
This repository was archived by the owner on Oct 1, 2020. It is now read-only.

refactored pip and py commands to a function and fixed the use of -E in the pip install command which fails - #1

Closed
amitelad7 wants to merge 4 commits into
poise:masterfrom
amitelad7:master
Closed

refactored pip and py commands to a function and fixed the use of -E in the pip install command which fails#1
amitelad7 wants to merge 4 commits into
poise:masterfrom
amitelad7:master

Conversation

@amitelad7

Copy link
Copy Markdown

refactored pip and py commands to a function and fixed the use of -E in the pip install command which fails

@sethvargo

Copy link
Copy Markdown
Contributor

Hey @amitelad7! Thank you for supporting the Opscode Cookbooks! Our process has a couple prerequisites before we can merge your contribution. We need to ensure you've completed a Contributor License Agreement (CLA) and a ticket on our ticket tracker for the release workflow. Pull requests are optional, but should always include the ticket number that they're related to for cross-referencing. Please take a moment to review the below wiki page for the appropriate steps:

Also, it looks like this will not merge cleanly. Could yo please rebase off master?

Comment thread providers/django.rb

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like manage.py should be refered to as an attribute that has a default value of "manage.py". In newer Django versions manage.py isn't in the root of the project directory, so this would only work for those projects.

What about something like:

::File.join( nr.virtualenv, "bin", "python", nr.manage_file)

Where manage_file is a django resource?

@coderanger

Copy link
Copy Markdown
Member

This is all now handled down in poise-python.

@coderanger coderanger closed this Oct 5, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants