refactored pip and py commands to a function and fixed the use of -E in the pip install command which fails - #1
refactored pip and py commands to a function and fixed the use of -E in the pip install command which fails#1amitelad7 wants to merge 4 commits into
Conversation
…pip install command which fails
|
Hey @amitelad7! Thank you for supporting the Opscode Cookbooks! Our process has a couple prerequisites before we can merge your contribution. We need to ensure you've completed a Contributor License Agreement (CLA) and a ticket on our ticket tracker for the release workflow. Pull requests are optional, but should always include the ticket number that they're related to for cross-referencing. Please take a moment to review the below wiki page for the appropriate steps:
Also, it looks like this will not merge cleanly. Could yo please rebase off master? |
There was a problem hiding this comment.
I feel like manage.py should be refered to as an attribute that has a default value of "manage.py". In newer Django versions manage.py isn't in the root of the project directory, so this would only work for those projects.
What about something like:
::File.join( nr.virtualenv, "bin", "python", nr.manage_file)
Where manage_file is a django resource?
|
This is all now handled down in |
refactored pip and py commands to a function and fixed the use of -E in the pip install command which fails