fetch.custom: Allow for partial resuming#464
Open
swagtoy wants to merge 1 commit intopkgcore:masterfrom
Open
Conversation
eli-schwartz
suggested changes
Feb 12, 2026
Author
|
gonna change this to just start downloading straight to .partial entirely, actually. |
This will attempt to download all files as XXX._partial_. The file will rename to XXX upon success. Correlatively, this also fixes the issue where interrupted downloads (i.e. pkgdev manifest) ended up counting as fetched, requiring the user to manually delete them to continue. Closes: pkgcore#52 Signed-off-by: Swagtoy <[email protected]>
swagtoy
force-pushed
the
keyboard-interrupt-delete
branch
from
8279625 to
6145ffa
Compare
swagtoy
commented
Feb 12, 2026
Comment on lines
+147
to
+150
| if 0 == spawn_bash( | ||
| command % {"URI": next(uris), "FILE": f"{target.filename}._partial_"}, **spawn_opts | ||
| ): | ||
| os.rename(f"{path}._partial_", path) |
Author
There was a problem hiding this comment.
What should I do about this on error? I'm not super familiar on what would be wise to do in such a case.
swagtoy
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will attempt to download all files as XXX.partial. The file
will rename to XXX upon success.
Correlatively, this also fixes the issue where interrupted
downloads (i.e. pkgdev manifest) ended up counting as fetched,
requiring the user to manually delete them to continue.