Add package tags as a semantic entity#929
Merged
Ducasse merged 1 commit intopillar-markup:devfrom Aug 2, 2025
Merged
Conversation
Co-Authored-By: Matija Kljajic <[email protected]>
2df4eb0 to
1e1784d
Compare
Contributor
|
Thanks I will have a look. |
Contributor
|
I know that the existing code is using this getX stuff. |
Contributor
Author
|
Yes, we continued the code following what was already there. Now it's probably time to improve it. OTOH there's no test on this PR and we are adding a new feature. That's not right :P My rewrite would be:
|
Contributor
|
I checked and it looks ok for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way we can quickly reference and navigate to a given package tag.
Made during the pharo sprint with @matijakljajic