Skip to content

Fix unreadable code in Pharo Light theme#858

Merged
Ducasse merged 1 commit intodevfrom
fix_unreadable_text_in_PharoLightTheme
Aug 15, 2024
Merged

Fix unreadable code in Pharo Light theme#858
Ducasse merged 1 commit intodevfrom
fix_unreadable_text_in_PharoLightTheme

Conversation

@hernanmd
Copy link
Contributor

Fix an issue reported in pharo-project/pharo#16876 that causes all Microdown Smalltalk code to be unreadable in the Calypso class comments and documentation browser.

Now Microdown code style follows the user's code style settings. This is done by resetting the textAttributes variable in the Microdown Smalltalk text styler during initialization, so it uses the user's configured code style.

Screenshot 2024-08-14 at 19 30 24

…so it uses the user's configured code style.
@hernanmd hernanmd added the bug Something isn't working label Aug 14, 2024
@hernanmd hernanmd self-assigned this Aug 14, 2024
@hernanmd hernanmd requested a review from Ducasse August 14, 2024 17:43
@hernanmd hernanmd added the document browser Document browser and rich text presenter label Aug 14, 2024
@Ducasse
Copy link
Contributor

Ducasse commented Aug 15, 2024

Tx hernan!

@Ducasse Ducasse merged commit 466957f into dev Aug 15, 2024
@hernanmd
Copy link
Contributor Author

In the latest P13 this PR isn't integrated yet, is that expected?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working document browser Document browser and rich text presenter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants