Add numeric check on unary plus and unary minus#273
Merged
ondrejmirtes merged 1 commit intophpstan:2.0.xfrom Jul 21, 2025
Merged
Add numeric check on unary plus and unary minus#273ondrejmirtes merged 1 commit intophpstan:2.0.xfrom
ondrejmirtes merged 1 commit intophpstan:2.0.xfrom
Conversation
VincentLanglet
force-pushed
the
unaryCheck
branch
3 times, most recently
from
dc350fa to
b383425
Compare
ondrejmirtes
requested changes
Jul 17, 2025
VincentLanglet
force-pushed
the
unaryCheck
branch
from
b383425 to
859d1e6
Compare
Member
|
Nice, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The operation
$a + $band$a - $bwere checked but it was mising for the unary usage of these operators+$aor-$a.Then, I plan to add such check for bitwise operators:
&(AND)|(OR)<<(Left shift)>>(Right shift)^(XOR)I assume it should be behind a new config option
numericOperandsInBitwiseOperators@ondrejmirtes ?