Skip to content

Move option definition to phpactor.vim #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dantleech merged 1 commit into from
Nov 6, 2019
Merged

Move option definition to phpactor.vim #839

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion autoload/phpactor/quickfix.vim
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
function! phpactor#quickfix#strategy() abort
if !has_key(g:, 'PhpactorQuickfixStrategy')
if (g:PhpactorQuickfixStrategy == v:null)
return s:auto_detect_strategy()
endif

Expand Down
4 changes: 4 additions & 0 deletions plugin/phpactor.vim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,10 @@ if !exists('g:phpactorCompletionIgnoreCase')
let g:phpactorCompletionIgnoreCase = 1
endif

if !exists('g:PhpactorQuickfixStrategy')
let g:PhpactorQuickfixStrategy = v:null
Copy link
Copy Markdown
Contributor

@camilledejoye camilledejoye Nov 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
let g:PhpactorQuickfixStrategy = v:null
let g:PhpactorQuickfixStrategy = function('phpactor#quickfix#fzf')

We don't need v:null since we already handle a default.
We cound even make s:auto_detect_strategy() public, something like phpactor#quickfix#default_strategy()
So we can use it to initialize the config variable and keep the same logic.

endif

if g:phpactorOmniAutoClassImport == v:true
autocmd CompleteDone *.php call phpactor#_completeImportClass(v:completed_item)
endif
Expand Down