gh-2913: avoid infinite loop when resolving constant type#2943
Merged
gh-2913: avoid infinite loop when resolving constant type#2943
Conversation
When we have a cycle such as `declare('Foo', Foo)` PHP will bail at
runtime because it will evaluate `Foo` before `declare`. Phpactor will
evalute `Foo` lazily - but even if it located it eagerly (bad for
performance) the indxer _will find_ the constant, because the indexer
doesn't know that the value causes a cycle.
for now we just avoid resolving values if they are QualifiedName's.
dantleech
force-pushed
the
gh-2913-infinite-loop
branch
from
a25a09b to
a22af93
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we have a cycle such as
declare('Foo', Foo)PHP will bail at runtime because it will evaluateFoobeforedeclare. Phpactor will evaluteFoolazily - but even if it located it eagerly (bad for performance) the indxer will find the constant, because the indexer doesn't know that the value causes a cycle.for now we only evaluate literal values.
Fixes #2913