Only use the snippet formatter if it also can format the snippet#2898
Merged
dantleech merged 4 commits intophpactor:masterfrom Jun 28, 2025
Merged
Only use the snippet formatter if it also can format the snippet#2898dantleech merged 4 commits intophpactor:masterfrom
dantleech merged 4 commits intophpactor:masterfrom
Conversation
Contributor
Author
|
I can't reproduce the error locally. But should be unrelated. |
Collaborator
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2896
When the snippet completions is disabled the snippetformatter has no formatters attached. So it crashes when trying to format a method. Now we just don't provide any snippets for the user if the formatter does not support it.