Gh 2729: Diagnostic codes and disabling#2781
Merged
Conversation
dantleech
commented
Nov 16, 2024
lib/Extension/LanguageServer/DiagnosticProvider/AggregateDiagnosticsProvider.php
Show resolved
Hide resolved
dantleech
commented
Nov 16, 2024
lib/Extension/LanguageServerWorseReflection/DiagnosticProvider/WorseDiagnosticProvider.php
Outdated
Show resolved
Hide resolved
dantleech
force-pushed
the
gh-2729-disable-diagnostic
branch
from
084dcb0 to
f19724b
Compare
dantleech
added a commit
that referenced
this pull request
Nov 16, 2024
- Show provider ID as code if no code present - Add diagnostic codes to all WR diagnostics - Always show a diagnostic code - Remove redundant `name` method on diagnostic provider - Add `language_server.diagnostic_ignore_cores` option.
dantleech
force-pushed
the
gh-2729-disable-diagnostic
branch
from
e9a77d9 to
4ff7f60
Compare
- Show provider ID as code if no code present - Add diagnostic codes to all WR diagnostics - Always show a diagnostic code - Remove redundant `name` method on diagnostic provider - Add `language_server.diagnostic_ignore_cores` option.
dantleech
force-pushed
the
gh-2729-disable-diagnostic
branch
from
4ff7f60 to
1de0329
Compare
This was referenced Nov 16, 2024
|
Typo in the post: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gh-2781: show diagnostic codes and allow them to be ignored
namemethod on diagnostic providerlanguage_server.diagnostic_ignore_coresoption.