Fixing method updating when return type is nullable.#2779
Merged
dantleech merged 2 commits intophpactor:masterfrom Nov 16, 2024
Merged
Fixing method updating when return type is nullable.#2779dantleech merged 2 commits intophpactor:masterfrom
dantleech merged 2 commits intophpactor:masterfrom
Conversation
mamazu
force-pushed
the
phpactor-2778
branch
3 times, most recently
from
82dcb65 to
f4d3d7d
Compare
mamazu
force-pushed
the
phpactor-2778
branch
from
f4d3d7d to
c7261dd
Compare
mamazu
changed the title
mamazu
commented
Nov 16, 2024
Comment on lines
+223
to
+225
| if ($returnType === '') { | ||
| return; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Do we also want to remove the return type when phpactor renders it as empty?
Collaborator
|
🙇 |
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #2778
When updating a method's return type the
TextEditupdates only the type list which is correct unless there is a nullable token at the beginning:This is the part that was being replaced. This PR will also include the question mark operator.