Skip to content

fix: fix render of nullable type#2778

Closed
jeremyFreeAgent wants to merge 1 commit intophpactor:masterfrom
jeremyFreeAgent:fix/nullable-type-render
Closed

fix: fix render of nullable type#2778
jeremyFreeAgent wants to merge 1 commit intophpactor:masterfrom
jeremyFreeAgent:fix/nullable-type-render

Conversation

@jeremyFreeAgent
Copy link
Copy Markdown

@jeremyFreeAgent jeremyFreeAgent commented Nov 15, 2024 •
edited
Loading

I've noticed that strange behavior when running the class:transform cli on interfaces:

 interface Animal
 {
-    public function jump(): ?Foo;
+    public function jump(): ? ?Foo;
 }

That PR should fix that.

@mamazu mamazu mentioned this pull request Nov 16, 2024
Merged
@mamazu
Copy link
Copy Markdown
Contributor

mamazu commented Nov 16, 2024

Hey, thank you for the contribution. However it seems like the issue is the underlying logic that updates the methods. If you're curious feel free to check out the linked PR.

@mamazu
Copy link
Copy Markdown
Contributor

mamazu commented Nov 16, 2024

The other PR is merged, can you check if that solved your problem?

@dantleech dantleech closed this Nov 16, 2024
@jeremyFreeAgent
Copy link
Copy Markdown
Author

jeremyFreeAgent commented Nov 17, 2024

The problem is resolved. Thanks!

@jeremyFreeAgent jeremyFreeAgent deleted the fix/nullable-type-render branch November 17, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jeremyFreeAgent @mamazu @dantleech