feat(phpstan): support opt-out of using a temporary file for linting#2764
Merged
dantleech merged 4 commits intophpactor:masterfrom Oct 24, 2024
Merged
feat(phpstan): support opt-out of using a temporary file for linting#2764dantleech merged 4 commits intophpactor:masterfrom
dantleech merged 4 commits intophpactor:masterfrom
Conversation
This ensures paths in phpstan config are respected. When using temporary files, PHPStan will not be able to relate the Note that this prevents as-you-type diagnostics, because only saved changes can be checked with PHPStan. Ref phpactor#2763
tsterker
force-pushed
the
phpstan-tmp-file-opt-out
branch
from
c5f1f0a to
3d4aea0
Compare
dantleech
reviewed
Oct 23, 2024
lib/Extension/LanguageServerPhpstan/Model/Linter/PhpstanLinter.php
Outdated
Show resolved
Hide resolved
dantleech
reviewed
Oct 23, 2024
| $phpstanProcess = $this->createMock(PhpstanProcess::class); | ||
| $phpstanProcess->expects($this->once()) | ||
| ->method('analyse') | ||
| // ->with($this->stringContains(sys_get_temp_dir() . '/phpstanls')); |
tsterker
commented
Oct 23, 2024
lib/Extension/LanguageServerPhpstan/Tests/LanguageServerPhpstanExtensionTest.php
Show resolved
Hide resolved
dantleech
reviewed
Oct 24, 2024
|
|
||
| class LanguageServerPhpstanExtensionTest extends TestCase | ||
| { | ||
| public function testParam_tmp_file_disabled(): void |
Collaborator
|
thanks! |
dantleech
added a commit
that referenced
this pull request
Nov 30, 2024
dantleech
added a commit
that referenced
this pull request
Nov 30, 2024
|
This maybe unrelated, but I'm not able to use this configuration option. I'm installing it via nix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for a new
language_server_phpstan.tmp_file_disabledparameter which defaults tofalse.Disabling the use of temporary files ensures paths in phpstan config are respected. When using temporary files, PHPStan will not be able to relate the relative paths/patterns to the currently running temporary file path/name.
Note that this prevents as-you-type diagnostics, because only saved changes can be checked with PHPStan.
Ref #2763