Restrict attribute completion using targets#2629
Merged
dantleech merged 31 commits intophpactor:masterfrom Oct 22, 2025
Merged
Conversation
przepompownia
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
przepompownia
commented
Apr 16, 2024
to determine attribute flags. IndexedNameSearcher can longer search attributes with no specific tagret.
Contributor
Author
|
@dantleech are you still not interested in reviewing this proposition? |
Collaborator
|
let's merge it after the release I'll make today then I'll be able to evaluate it. |
Collaborator
|
💥 |
Contributor
Author
In other words, let's see what else can explode 😛 Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2199