Fix renaming attributed class members#2627
Merged
dantleech merged 21 commits intophpactor:masterfrom Apr 6, 2024
Merged
Conversation
Collaborator
|
is this a parser bug though? and if not does the same apply to properties? |
Contributor
Author
|
It doesn't look like a parser bug (additionally, tree-sitter also considers attribute list to be part of method declaration etc). It seems to be good news - I utilize it in #2629 (moving from an attribute up to method declaration for example). |
przepompownia
changed the title
Contributor
Author
|
It seems to be ready to review for class members. |
dantleech
approved these changes
Apr 6, 2024
Collaborator
|
thanks! |
Contributor
Author
|
Thank you especially for the hint - it significantly reduced investigating. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2577