Skip to content

[rpc] Destructive actions in collections always act on the original source.  #848

@dantleech

Description

@dantleech

When executing multiple actions with a Collection respponse, the original source is always used, instead of the modified version from the previous action.

This is hard to solve without serious refactoring.

Because Phpactor is stateless, the client would need to provide up-to-date source code for the callback's source parameter.

  • We could refer to files by reference (e.g. URI) instead of only providing the source code.
  • The actual files (i.e. the ones we are working with) can be transferred as a generic field on the request / response objects.
  • The Client can then ensure that the files are up-to-date, and we need not supply the source code in callbacks, only the file references.

This could mean refactoring all handlers to supply a reference, and the client will need to ensure that:

  • It sends the reference instead of the current source field.
  • That on initial requests it provides the subject-file in the additional workspace field.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions